Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw if no account-holder is found #14926

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Don't throw if no account-holder is found #14926

merged 2 commits into from
Oct 31, 2024

Conversation

melohagan
Copy link
Collaborator

Description

Fix

@melohagan melohagan requested a review from a team as a code owner October 31, 2024 08:52
@melohagan melohagan requested review from samwho and removed request for a team October 31, 2024 08:52
@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Oct 31, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

shogunpurple
shogunpurple approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melohagan melohagan enabled auto-merge (squash) October 31, 2024 08:55
@shogunpurple shogunpurple merged commit 220d570 into master Oct 31, 2024
13 checks passed
@shogunpurple shogunpurple deleted the fix/no-account-holder branch October 31, 2024 08:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shogunpurple shogunpurple shogunpurple approved these changes

@samwho samwho Awaiting requested review from samwho samwho is a code owner automatically assigned from Budibase/backend

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melohagan @shogunpurple